Block with statistics by lessons quantity #2616
Conversation
Renatavl
commented
Oct 14, 2024
Renatavl
commented
Renatavl
added
Frontend part
feature
Tutor
Renatavl
requested review from
YaroslavChuiko,
dudchakk,
ipasic-softserve,
YaroslavLys,
Mav-Ivan,
PavloDolia and
BohdanMylyi
| import QuantityLessonsChart from './QuantityLessonsChart' | ||
| import { useTranslation } from 'react-i18next' | ||
|
|
||
| const currencies = [ |
There was a problem hiding this comment.
relocate to .constants.tsx
|
|
||
| const currencies = [ | ||
| { | ||
| value: 'USD', |
There was a problem hiding this comment.
create enum for currencies
| } | ||
| ] | ||
|
|
||
| const subjects = [ |
There was a problem hiding this comment.
subjects should be taken from user mainSubjects
| } | ||
| ] | ||
|
|
||
| const years = [ |
| backgroundColor: '#79B260', | ||
| borderColor: '#79B260', |
| datasets: [ | ||
| { | ||
| label: 'Lessons', | ||
| data: [5, 5, 10, 10, 12, 15, 14, 14, 10, 10, 12, 12], |
There was a problem hiding this comment.
What does this data represent accepted offers?
| display: false | ||
| }, | ||
| ticks: { | ||
| color: '#455A64', |
| ] | ||
| } | ||
|
|
||
| const options = { |
There was a problem hiding this comment.
relocate to .constants.tsx
There was a problem hiding this comment.
This object directly belongs to component properties, but not a hardcoded value which is used as input data for the component. That's why it is better to leave it at the same place as the component
There was a problem hiding this comment.
I still don't understand why we can't move these constant values to constants.tsx file, because we store constants in separate files to avoid cluttering files with components
There was a problem hiding this comment.
you can move these constants to another file and just import them, because now the component is heavily cluttered
|
|
||
| const data = { | ||
| labels: [ | ||
| 'JAN', |
There was a problem hiding this comment.
its probably better to use Date here
There was a problem hiding this comment.
It is not needed because in the end result we will get the same results as with Date. We simply have a fixed list of months that doesn't change in any way and doesn't depend on anything.
There was a problem hiding this comment.
why is the QuantityLessonsChart component located in a folder meant for another component?
| ] | ||
| } | ||
|
|
||
| const options = { |
There was a problem hiding this comment.
I still don't understand why we can't move these constant values to constants.tsx file, because we store constants in separate files to avoid cluttering files with components
Renatavl
force-pushed
the
feature/459/statistics-block-with-lessons-quantity
branch
from
e8c10fd to
28db1e0
Compare
| { | ||
| value: 'Music' | ||
| }, | ||
|
|
There was a problem hiding this comment.
please remove the blank lines
| color: 'basic.darkGray', | ||
| mb: '5px' | ||
| }, | ||
|
|
Renatavl
force-pushed
the
feature/459/statistics-block-with-lessons-quantity
branch
from
28db1e0 to
dd0816e
Compare
|
Renatavl
deleted the
feature/459/statistics-block-with-lessons-quantity
branch
